JingsongLi commented on code in PR #8000:
URL: https://github.com/apache/paimon/pull/8000#discussion_r3519645976
##########
pom.xml:
##########
@@ -519,6 +519,19 @@ under the License.
</activation>
</profile>
+ <profile>
+ <!-- paimon-eslib depends on Java-11 eslib-api/eslib-core (Lucene
9.12), so it must be
+ built with JDK 11+. Activated only on JDK 11+ (like
paimon-iceberg) so the default
+ JDK-8 build skips it instead of failing the
RequireJavaVersion enforcer rule. -->
+ <id>paimon-eslib</id>
+ <modules>
+ <module>paimon-eslib</module>
+ </modules>
+ <activation>
+ <jdk>11</jdk>
Review Comment:
This only auto-activates the module on JDK 11, not on later JDKs. I verified
`mvn help:active-profiles -DskipTests` locally: with JAVA_HOME set to JDK 11
the `paimon-eslib` profile is active, but with JDK 17 or JDK 21 it is not, so
the new module is silently skipped in those builds despite the comment saying
JDK 11+. Please use a range such as `[11,)` (and keep the Spark-side profile
aligned) so Java 17/21 builds also compile and test `paimon-eslib`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
