CrownChu commented on PR #8000:
URL: https://github.com/apache/paimon/pull/8000#issuecomment-4958287727
Thanks — both issues have now been fixed.
1. SQL LIKE escaping (`5e6135ccc2`)
- `\` is now handled as Paimon's default SQL LIKE escape.
- Escaped `_`, `%`, and `\` are treated as literals, while unescaped
`_` and `%` remain wildcards.
- The regression test `likeHonorsSqlEscapeAndLuceneLiterals` covers
`admin\_%`, `admin\%%`, and `admin\\%`. The `admin\_%` case now consistently
returns exactly one match.
2. Concurrent reader lifecycle (`5e6135ccc2`)
- The complete lazy-load/search operation now holds the lifecycle read
lock.
- `close()` holds the write lock, so it cannot close resources while
`ensureLoaded()` is opening or publishing them.
- `closeWaitsForInFlightLoadAndClosesEveryStream` deterministically
verifies that close waits for an in-flight load and releases every opened
stream.
- `failedLazyLoadClosesStreamsBeforeRetry` covers cleanup after a
failed lazy load.
The branch has also been upgraded to ESLib 1.0.4 in `36bc216e26`.
Local verification:
`mvn -pl paimon-eslib clean -DwildcardSuites=none test`
Result: 32 tests passed, 0 failures.
`mvn -pl paimon-eslib -DskipTests package`
Result: BUILD SUCCESS.
回复 executor 的旧 review 线程：
Sorry for missing the reply on this thread. This was fixed in `31f1758c56`.
`READ_SEARCH_EXECUTORS` is now a `ConcurrentMap<Integer, ExecutorService>`
keyed by the resolved thread count:
- different configured thread counts receive different pools;
- the same resolved count reuses the same pool;
- `read-search-threads=0` always returns `null` and cannot reuse a
previously created pool.
Therefore the executor configuration is no longer first-use-wins. The
executor regression tests also cover configured/caller executor separation,
serial mode, and the nested-executor deadlock guard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
