irodriguezclaveria commented on code in PR #8452: URL: https://github.com/apache/paimon/pull/8452#discussion_r3546943070
########## paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/FlinkTableSinkBase.java: ########## Review Comment: Thanks, good point. So far I have validated it with deduplicate + none, which works correctly. For the other combinations, this is my understanding — could you confirm? Changelog producers: input: the docs say it expects the input to already be a complete changelog, so with key-only deletes it would forward incomplete deletes. Should we treat it as not compatible here? lookup / full-compaction: both reconstruct the complete changelog, so I would expect them to work with key-only deletes. Do you agree? Merge engines: partial-update: I think it works as long as delete handling is enabled (remove-record-on-delete), since it merges and removes by key. Is that correct? aggregate: this one probably does not work, because it needs the previous values to retract on updates and deletes, and a key-only delete does not carry them. Would you agree it should be blocked? first-row: it ignores updates and deletes by design, so a key-only delete would have no effect. I understand it does not really apply here — is that right? For the combinations that do not apply, I could document them as unsupported. I am not sure yet whether we also need a check or a test for that, or if documentation would be enough — what would you prefer? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
