leaves12138 commented on code in PR #8693:
URL: https://github.com/apache/paimon/pull/8693#discussion_r3596076103
##########
paimon-common/src/main/java/org/apache/paimon/utils/UriReaderFactory.java:
##########
@@ -35,14 +35,29 @@
/** A factory to create and cache {@link UriReader}. */
public class UriReaderFactory implements Serializable {
- private final CatalogContext context;
+ private static final long serialVersionUID = -8477284718943635074L;
+
+ @Nullable private final CatalogContext context;
+ @Nullable private final FileIO fileIO;
Review Comment:
1、FileIO should be transient
2、It seems strange to hold both fileIO and readers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
