leaves12138 commented on code in PR #8693:
URL: https://github.com/apache/paimon/pull/8693#discussion_r3596126382
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/FlinkRowWrapper.java:
##########
@@ -105,8 +105,36 @@ public FlinkRowWrapper(
boolean checkBlobDescriptorExists,
boolean writeNullOnFetchFailure,
Set<Integer> blobFields) {
+ this(
+ row,
+ new UriReaderFactory(catalogContext),
+ checkBlobDescriptorExists,
+ writeNullOnFetchFailure,
+ blobFields);
+ }
+
+ public static FlinkRowWrapper fromUriReaderFactory(
+ org.apache.flink.table.data.RowData row,
+ UriReaderFactory uriReaderFactory,
+ boolean checkBlobDescriptorExists,
+ boolean writeNullOnFetchFailure,
+ Set<Integer> blobFields) {
+ return new FlinkRowWrapper(
+ row,
+ uriReaderFactory,
+ checkBlobDescriptorExists,
+ writeNullOnFetchFailure,
+ blobFields);
+ }
+
+ private FlinkRowWrapper(
+ org.apache.flink.table.data.RowData row,
+ UriReaderFactory uriReaderFactory,
+ boolean checkBlobDescriptorExists,
+ boolean writeNullOnFetchFailure,
+ Set<Integer> blobFields) {
this.row = row;
- this.uriReaderFactory = new UriReaderFactory(catalogContext);
+ this.uriReaderFactory = uriReaderFactory;
Review Comment:
If FlinkRowWrapper with uriReaderFactory(fileIO), then it can't be
successfully serialize and deserialize. FileIO is not serializable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
