JingsongLi commented on code in PR #8635:
URL: https://github.com/apache/paimon/pull/8635#discussion_r3620049969
##########
paimon-core/src/main/java/org/apache/paimon/blob/PrimaryKeyBlobExternalizer.java:
##########
@@ -32,31 +34,52 @@
import org.apache.paimon.io.DataFilePathFactory;
import org.apache.paimon.types.ArrayType;
import org.apache.paimon.types.DataField;
+import org.apache.paimon.types.DataType;
import org.apache.paimon.types.DataTypeRoot;
+import org.apache.paimon.types.DataTypes;
+import org.apache.paimon.types.MapType;
import org.apache.paimon.types.RowKind;
import org.apache.paimon.types.RowType;
import org.apache.paimon.utils.IOUtils;
+import org.apache.paimon.utils.InternalRowUtils;
import org.apache.paimon.utils.RowDataToObjectArrayConverter;
import java.io.IOException;
import java.util.ArrayList;
-import java.util.Collections;
+import java.util.LinkedHashMap;
import java.util.List;
+import java.util.Map;
import java.util.Set;
import java.util.TreeSet;
+import static org.apache.paimon.types.BlobType.isBlobFileField;
import static org.apache.paimon.utils.Preconditions.checkArgument;
/** Externalizes primary-key BLOB values before they enter the MergeTree write
buffer. */
public class PrimaryKeyBlobExternalizer {
+ private static final RowType BLOB_ROW_TYPE = RowType.of(DataTypes.BLOB());
+
private final FileIO fileIO;
private final RowDataToObjectArrayConverter rowConverter;
- private final int[] blobFieldIndexes;
- private final boolean[] blobArrayFields;
- private final ManagedBlobPackWriter[] packWriters;
+ private final ManagedBlobField[] blobFields;
private final List<Path> uncommittedPacks;
+ public PrimaryKeyBlobExternalizer(
Review Comment:
Do not add constructor for test codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
