steFaiz commented on code in PR #8635:
URL: https://github.com/apache/paimon/pull/8635#discussion_r3620128794
##########
paimon-api/src/main/java/org/apache/paimon/types/BlobType.java:
##########
@@ -118,6 +118,25 @@ public static boolean isBlobFileField(DataType type) {
if (type.getTypeRoot() == DataTypeRoot.ARRAY) {
return ((ArrayType) type).getElementType().getTypeRoot() ==
DataTypeRoot.BLOB;
}
+ if (type.getTypeRoot() == DataTypeRoot.MAP) {
+ MapType mapType = (MapType) type;
+ return mapType.getValueType().getTypeRoot() == DataTypeRoot.BLOB
+ && isSupportedMapBlobKeyType(mapType.getKeyType());
+ }
return false;
}
+
+ private static boolean isSupportedMapBlobKeyType(DataType keyType) {
Review Comment:
I was meant to fast-fail on creating table. Do you think we do not have to
fast fail here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
