JingsongLi commented on PR #560: URL: https://github.com/apache/paimon-rust/pull/560#issuecomment-5035386414
**1. Missing authorization check** > `BatchVectorSearchBuilder::execute()` no longer calls `CoreOptions::ensure_read_authorized()`, although the previous implementation performed this check before validation and empty-table fast paths. This method returns data-derived row IDs and scores outside `TableScan` / `TableRead`, so a table with `query-auth.enabled=true` can bypass the fail-closed read authorization through the batch scored-search API. Please restore the authorization check at the beginning of `execute()` and add a batch-specific regression test. **2. `ARRAY<FLOAT>` with Lumina is incorrectly handled as vindex** > `pk_vector_query_dimension()` unconditionally uses `VindexVectorIndexOptions` for every `ARRAY<FLOAT>` column. For a valid PK-vector configuration using `lumina` or `lumina-vector-ann`, this fails with `Unsupported vindex index type` before planning, including on an empty table. Please resolve the dimension according to the configured backend: use the effective `lumina.index.dimension` for Lumina and `VindexVectorIndexOptions` only for vindex backends. A regression test covering `ARRAY<FLOAT>` with Lumina would also be useful. **3. Default projection no longer rejects reserved-column conflicts** > The previous implementation validated the resolved field list after applying the projection, which also caught reserved-name conflicts in the default projection. The new resolver only validates explicitly requested projection names. As a result, a table containing a user column such as `__paimon_search_score`, `_PKEY_VECTOR_POSITION`, or `_ROW_ID` can silently pass on an empty result and may produce duplicate or incorrectly interpreted metadata columns for non-empty results. Please restore the post-resolution reserved-field validation for both the single-query and batch resolvers, along with the removed default-projection regression tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
