JunRuiLee commented on PR #560: URL: https://github.com/apache/paimon-rust/pull/560#issuecomment-5036028466
Addressed in fd72a9a (fixes) and 5fd4157 (cleanup): **1. Missing authorization check** — `BatchVectorSearchBuilder::execute()` now calls `ensure_read_authorized()` at the very top, before config validation and any fast path, matching `execute_read` and the single-query builder. A `query-auth.enabled=true` table previously returned empty results on an empty snapshot and bypassed the fail-closed guard; it now fails closed. Added a batch-specific regression test. **2. `ARRAY<FLOAT>` with Lumina** — `pk_vector_query_dimension()` now resolves the dimension per the configured backend: Lumina via `LuminaVectorIndexOptions` (`lumina.index.dimension`), vindex/IVF via `VindexVectorIndexOptions`. A valid Lumina `ARRAY<FLOAT>` PK-vector column is no longer rejected as `Unsupported vindex index type` before planning (including on an empty table). Added a regression test covering `ARRAY<FLOAT>` + Lumina. **3. Default projection reserved-column conflicts** — both `resolve_materialize_read_type` resolvers (single-query and batch) now validate the *resolved* field list against the reserved metadata names, so the default all-columns projection also rejects a colliding user column, not only names in an explicit projection. The explicit pre-check is kept so a requested reserved name that is not a real column still fails as a reserved-column error rather than "column not found". Restored the default-projection regression tests for both resolvers. Separately, dropped the stale `_PKEY_VECTOR_SCORE` reserved name (5fd4157): it was the score column's pre-rename name and nothing emits it anymore — the injected metadata columns are `__paimon_search_score`, `_PKEY_VECTOR_POSITION`, and `_ROW_ID`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
