shyjsarah commented on code in PR #623:
URL: https://github.com/apache/paimon-rust/pull/623#discussion_r3656960936
##########
crates/integrations/datafusion/src/sql_context.rs:
##########
@@ -198,7 +198,12 @@ impl SQLContext {
Some(session_state),
)),
);
- register_table_functions(&self.ctx, &catalog,
default_db.unwrap_or("default"));
+ register_table_functions(
+ &self.ctx,
+ &catalog,
+ default_db.unwrap_or("default"),
+ self.dynamic_options.clone(),
Review Comment:
Good catch. The DE vector-search path reads the latest index snapshot, so
forwarding a time-travel selector could indeed search the latest snapshot and
materialize rows from an older one. I updated the patch to filter
`scan.version`, `scan.timestamp-millis`, `scan.snapshot-id`, and
`scan.tag-name` while still forwarding supported options such as
`blob-as-descriptor`. The regression test now covers both behaviors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
