shyjsarah commented on code in PR #623:
URL: https://github.com/apache/paimon-rust/pull/623#discussion_r3671325976
##########
crates/integrations/datafusion/src/vector_search.rs:
##########
@@ -426,6 +461,21 @@ impl ExecutionPlan for VectorSearchExec {
}
}
+/// Vector search currently resolves candidates from the latest snapshot, so
forwarding a
+/// time-travel selector would search one snapshot and materialize rows from
another.
+fn vector_search_dynamic_options(dynamic_options: &DynamicOptions) ->
HashMap<String, String> {
+ let mut options = dynamic_options.read().unwrap().clone();
+ for key in [
+ SCAN_VERSION_OPTION,
Review Comment:
Good point. We can keep these options as-is. I updated vector search to
honor the resolved time-travel snapshot instead of always using the latest
snapshot, and added regression tests covering `scan.version` together with
`blob-as-descriptor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
