jordepic opened a new pull request, #8874:
URL: https://github.com/apache/paimon/pull/8874

   ### Purpose
   
   Fixes #8873.
   
   `TypeCheckUtils.isComparable` admits BINARY and VARBINARY, and primary keys 
may contain them, but `SliceComparator` cast every field value to `Comparable` 
— `byte[]` is not, so any sorted-lookup-store seek over a binary key field 
(lookup compaction, deletion-vector maintenance, lookup changelog producer) 
threw `ClassCastException`. Compare binary fields with 
`SortUtil.compareBinary`, the same unsigned lexicographic order `BinaryRow` 
uses, so lookup files order consistently with the rest of the merge tree.
   
   ### Tests
   
   `RowCompactedSerializerTest.BinaryFieldTest`: serializer round-trips over an 
`(INT, BYTES)` row type plus a slice-comparator test covering 
less/greater/equal and the unsigned edge (`0xFF` orders above `0x01`).
   
   ### API and Format
   
   No changes.
   
   ### Documentation
   
   No changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to