sundapeng commented on PR #8878: URL: https://github.com/apache/paimon/pull/8878#issuecomment-5098374431
Closing this for now. The failure is confined to the opt-in value-only layout (`format-table.partition-path-only-value=true`, default false). With the default `key=value` layout the null partition lives in `dt=__DEFAULT_PARTITION__`, whose first character is `d`, so the hidden-directory rule never touches it — and the rescue branch in `isHiddenFile` is itself guarded by `onlyValueInPath`, which makes this patch a no-op outside that layout. It is also only half of the class. A partition value that merely starts with `_` or `.` (`dt='_abc'`) fails the same way in the same layout, because neither character is in `CHAR_TO_ESCAPE` and the directory is written bare. Fixing only the default partition name leaves the neighbouring case behaving differently for no reason a user could infer. The root of both is that a value-only layout puts partition directories and committer staging directories on the same level with no way to tell them apart by name, so relaxing the rule would start registering `_temporary`/`__magic` trees as partitions. That needs a decision rather than a patch, and we would rather take it as a whole than land a partial fix that makes the remaining half harder to see. Recording it as a known issue on our side. Happy to reopen or file an issue for the naming ambiguity if that is useful to anyone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
