ZZZxDong commented on PR #8837:
URL: https://github.com/apache/paimon/pull/8837#issuecomment-5112298925
@JingsongLi Makes sense, I will follow the Flink pattern: drop
`delete.point-delete.enabled` and gate the fast path on
`!delete.force-produce-changelog` instead.
One call needed from you first, since making it default changes an asserted
contract: `TableValuedFunctionsTest` asserts that an incremental / `audit_log`
read of a deleted row carries its old field values (`Row("-D", 1, 11)`). With
the fast path on by default it becomes `Row("-D", 1, null)`, because those old
values are exactly what we skip reading. Is it OK to redefine this as "non-key
columns of a point-delete `-D` row are NULL unless
`delete.force-produce-changelog=true`" and update the test accordingly?
I would also fall back to the scan path when `changelog-producer != none`,
otherwise a streaming consumer would silently retract with NULL field values
instead of the old ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
