JingsongLi commented on PR #8837: URL: https://github.com/apache/paimon/pull/8837#issuecomment-5212766938
- The PR description declares `delete.point-delete.enabled=false`, indicating it's disabled by default, but the code lacks this configuration and check, while tests explicitly verify "enabled by default." - This changes the DELETE semantics by default: non-primary key fields in incremental/`audit_log` become NULL, non-existent keys generate tombstones, and even create new partitions. - The `max-rows=1M` in the description is inconsistent with the code's default `10000`. 21 new Spark tests passed, but these tests solidified the incorrect default behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
