JingsongLi commented on PR #659:
URL: https://github.com/apache/paimon-rust/pull/659#issuecomment-5175023983

   - `write_arrow_batch` appends the internal `_VALUE_KIND` column via 
`enrich_rowkind_batch`.
   - `prepare_commit` calls `binary_row_batch_size(batch, 
table.schema().fields())` when planning the bucket, which requires the number 
of batch columns to be strictly equal to the number of fields in the user table.
   - I added a temporary regression test: `bucket=-2`, PK table, 
`rowkind.field=op`, the write succeeded but `prepare_commit` consistently 
failed: `BinaryRow size planning expected 3 columns, got 4`.
   - It is recommended to exclude the internal `_VALUE_KIND` during sizing and 
add a fixed-bucket + rowkind regression test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to