JingsongLi commented on code in PR #659:
URL: https://github.com/apache/paimon-rust/pull/659#discussion_r3720222892
##########
crates/paimon/src/table/write_builder.rs:
##########
@@ -120,17 +159,42 @@ struct PaimonWriteBuilder<'a> {
table: &'a Table,
commit_user: String,
overwrite: bool,
+ postpone_fixed_bucket: bool,
+ postpone_bucket_plan: Option<PostponeBucketPlan>,
}
impl<'a> PaimonWriteBuilder<'a> {
pub fn new(table: &'a Table) -> Self {
+ let schema = table.schema();
+ let options = CoreOptions::new(schema.options());
+ let postpone_fixed_bucket = options.bucket() == POSTPONE_BUCKET
Review Comment:
Why enabling fixed_bucket write by default? Can you create a real
`PostponeFixedBucketWriteBuilder`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
