jerry-024 commented on code in PR #73:
URL:
https://github.com/apache/paimon-vector-index/pull/73#discussion_r3764168923
##########
core/src/ivfpq.rs:
##########
@@ -2365,13 +2444,44 @@ pub fn
search_batch_reader_roaring_filter_with_reuse_mode_and_budget<R: SeekRead
reuse_mode: IvfPqBatchTableReuseMode,
reuse_max_bytes: usize,
) -> io::Result<(Vec<i64>, Vec<f32>)> {
- let filter = decode_roaring_filter(roaring_filter_bytes)?;
- search_batch_reader_filter_with_reuse_mode_and_budget(
+ search_batch_reader_roaring_filter_with_reuse_mode_and_budget_range(
reader,
queries,
nq,
k,
+ 0,
nprobe,
+ &[],
+ &[],
+ roaring_filter_bytes,
+ reuse_mode,
+ reuse_max_bytes,
+ )
+}
+
Review Comment:
<!-- dlf-review -->
**[MAJOR]** The roaring-filter batch-search wrapper does not compile.
`search_batch_reader_roaring_filter_with_reuse_mode_and_budget_range`
expects `(k, probe_start, probe_end, seed_ids, seed_distances, ...)`, but this
call passes `(k, 0, 0, nprobe, &[], &[], ...)`. That supplies 13 arguments and
shifts `nprobe: usize` into the `seed_ids: &[i64]` position. Remove the extra
`0` so the call passes `k, 0, nprobe, &[], &[], ...`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
