shyjsarah commented on code in PR #73:
URL:
https://github.com/apache/paimon-vector-index/pull/73#discussion_r3764365822
##########
core/src/ivfpq.rs:
##########
@@ -2365,13 +2444,44 @@ pub fn
search_batch_reader_roaring_filter_with_reuse_mode_and_budget<R: SeekRead
reuse_mode: IvfPqBatchTableReuseMode,
reuse_max_bytes: usize,
) -> io::Result<(Vec<i64>, Vec<f32>)> {
- let filter = decode_roaring_filter(roaring_filter_bytes)?;
- search_batch_reader_filter_with_reuse_mode_and_budget(
+ search_batch_reader_roaring_filter_with_reuse_mode_and_budget_range(
reader,
queries,
nq,
k,
+ 0,
nprobe,
+ &[],
+ &[],
+ roaring_filter_bytes,
+ reuse_mode,
+ reuse_max_bytes,
+ )
+}
+
Review Comment:
Thanks for checking this. I verified the call on the current PR head. It
passes `k, 0, nprobe, &[], &[]`, where `0` is `probe_start` and `nprobe` is
`probe_end`; there is no second `0`.
The argument count and types match the range helper signature. The targeted
Roaring-filter batch test and the full CI also pass on this commit, so no code
change is needed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
