zjw1111 commented on code in PR #199:
URL: https://github.com/apache/paimon-cpp/pull/199#discussion_r3774312190
##########
src/paimon/core/core_options.cpp:
##########
@@ -802,6 +803,12 @@ struct CoreOptions::Impl {
std::string scan_timestamp_str;
PAIMON_RETURN_NOT_OK(parser.Parse(Options::SCAN_TIMESTAMP,
&scan_timestamp_str));
PAIMON_RETURN_NOT_OK(parser.Parse(Options::SCAN_TIMESTAMP_MILLIS,
&scan_timestamp_millis));
+ PAIMON_RETURN_NOT_OK(
+ parser.Parse(Options::REALTIME_READ_VIEW_TTL_MILLIS,
&realtime_read_view_ttl_millis));
Review Comment:
and `read-view-ttl-millis` -> `read-view-ttl`
##########
include/paimon/defs.h:
##########
@@ -540,6 +540,10 @@ struct PAIMON_EXPORT Options {
/// "scan.timestamp" can be used as an alternative string input for the
same mode.
static const char SCAN_TIMESTAMP_MILLIS[];
+ /// "realtime.read-view-ttl-millis" - Lifetime in milliseconds of a
real-time memory view
+ /// pinned by scan planning before reader creation. Default value is
300000.
Review Comment:
300000 -> use a human-readable value? 300s or 5min
##########
src/paimon/core/core_options.cpp:
##########
@@ -802,6 +803,12 @@ struct CoreOptions::Impl {
std::string scan_timestamp_str;
PAIMON_RETURN_NOT_OK(parser.Parse(Options::SCAN_TIMESTAMP,
&scan_timestamp_str));
PAIMON_RETURN_NOT_OK(parser.Parse(Options::SCAN_TIMESTAMP_MILLIS,
&scan_timestamp_millis));
+ PAIMON_RETURN_NOT_OK(
+ parser.Parse(Options::REALTIME_READ_VIEW_TTL_MILLIS,
&realtime_read_view_ttl_millis));
Review Comment:
use `ParseTimeDuration`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
