lxy-9602 commented on code in PR #199:
URL: https://github.com/apache/paimon-cpp/pull/199#discussion_r3800195381
##########
src/paimon/core/table/source/realtime_split.h:
##########
@@ -59,25 +74,27 @@ class RealtimeSplit : public Split {
return disk_splits_;
}
- const std::shared_ptr<MemIndexer>& Indexer() const {
- return indexer_;
+ int64_t CommittedOffset() const {
+ return committed_offset_;
}
- const std::shared_ptr<MemReadView>& ReadView() const {
- return read_view_;
+ int64_t MemoryUpperOffset() const {
+ return memory_upper_offset_;
}
- int64_t CommittedOffset() const {
- return committed_offset_;
+ const std::string& OpaqueTicket() const {
+ return opaque_ticket_;
}
private:
+ int32_t version_;
+ std::optional<int64_t> snapshot_id_;
std::map<std::string, std::string> partition_;
int32_t bucket_;
std::vector<std::shared_ptr<Split>> disk_splits_;
- std::shared_ptr<MemIndexer> indexer_;
- std::shared_ptr<MemReadView> read_view_;
int64_t committed_offset_;
Review Comment:
The reason I originally chose a closed interval on both ends was to reuse
the existing Range class in Java/C++, but I agree that it introduces some
additional complexity in both understanding and implementation. I’ll remove the
realtime code’s dependency on Range and replace it with support based on a
left-closed, right-open OffsetRange type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
