u70b3 commented on PR #181: URL: https://github.com/apache/paimon-cpp/pull/181#issuecomment-5288739935
@zjw1111 No worries, and thanks for driving the aarch64 port! I took it for a proper spin on my local aarch64 machine (a 128-core Kunpeng-920): replicated the full CI aarch64 matrix locally — gcc debug/release, clang debug/release, ASan+UBSan, and TSan. Everything builds cleanly and the entire test suite passes (40/40). The port works well for my use case. 🎉 While validating, I also ran a deeper ARM portability sweep and found a few suspected/confirmed issues that #181 didn't cover, so I went ahead and fixed them locally: - a real double-checked-locking race in `Singleton<T>` — hidden by x86 TSO, but TSan-confirmed on aarch64 with torn reads observed under a 128-thread stress litmus - a TSan-confirmed race on `IOHook`'s `mode_` (fault-injection/test-only impact) - the plain-char INT8 pattern that survived #181 in `field_sum_agg.cpp` (latent, same bug class as the min/max fix) - a strict-aliasing UB in `SerializationUtils::DeserializeBinaryRow` (latent) - arch-divergent double→int conversions in `cache_manager.h` / `sst_file_writer.cpp` (latent, pathological configs only) Fixes plus deterministic TSan regression tests are in #203 — details and the red→green evidence are in the PR description. Happy to split the PR or adjust anything if you'd prefer a different shape! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
