zhuyaogai commented on code in PR #9247:
URL: https://github.com/apache/paimon/pull/9247#discussion_r3797373502
##########
docs/docs/flink/procedures.md:
##########
@@ -407,13 +407,13 @@ All available procedures are listed below.
<td>remove_orphan_files</td>
<td>
-- Use named argument<br/>
- CALL [catalog.]sys.remove_orphan_files(`table` => 'identifier',
older_than => 'olderThan', dry_run => 'dryRun', mode => 'mode') <br/><br/>
+ CALL [catalog.]sys.remove_orphan_files(`table` => 'identifier',
older_than => 'olderThan', dry_run => 'dryRun', mode => 'mode',
table_batch_size => 'tableBatchSize') <br/><br/>
Review Comment:
This parameter controls the number of tables included in each batch (each
submitted Flink job), rather than limiting the total number of tables to clean.
For example, 23 tables with a value of 10 will be processed in three
batches: 10, 10, and 3. All 23 tables will still be cleaned.
`max_table_number` might be interpreted as a limit on the total number of
tables to process. I think `table_batch_size` better reflects the current
semantics. Would `max_tables_per_batch` be clearer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
