zhuyaogai commented on code in PR #9247:
URL: https://github.com/apache/paimon/pull/9247#discussion_r3813936166
##########
docs/docs/flink/procedures.md:
##########
@@ -407,13 +407,13 @@ All available procedures are listed below.
<td>remove_orphan_files</td>
<td>
-- Use named argument<br/>
- CALL [catalog.]sys.remove_orphan_files(`table` => 'identifier',
older_than => 'olderThan', dry_run => 'dryRun', mode => 'mode') <br/><br/>
+ CALL [catalog.]sys.remove_orphan_files(`table` => 'identifier',
older_than => 'olderThan', dry_run => 'dryRun', mode => 'mode',
table_batch_size => 'tableBatchSize') <br/><br/>
Review Comment:
Hi @JingsongLi, could you elaborate a bit on what you have in mind with
`max_table_number`?
The current design submits all matched tables in sequential Flink jobs, and
this parameter controls how many tables are included in each job.
I'm not sure whether your suggestion is only about the parameter name, or
whether you have different semantics or an alternative design in mind. I'd like
to understand your intention before changing the API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
