ChaomingZhangCN commented on code in PR #198:
URL: https://github.com/apache/paimon-cpp/pull/198#discussion_r3800435027
##########
src/paimon/format/parquet/parquet_format_writer.h:
##########
@@ -72,7 +72,8 @@ class ParquetFormatWriter : public FormatWriter {
ParquetFormatWriter(std::unique_ptr<::parquet::arrow::FileWriter> writer,
const std::shared_ptr<ArrowOutputStreamAdapter>& out,
const std::shared_ptr<arrow::Schema>& schema, uint64_t
max_memory_use,
- const std::shared_ptr<arrow::MemoryPool>& pool);
+ const std::shared_ptr<arrow::MemoryPool>& pool,
+ bool needs_vector_conversion);
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
