JingsongLi commented on code in PR #726:
URL: https://github.com/apache/paimon-rust/pull/726#discussion_r3800981494
##########
crates/paimon/src/vindex/reader.rs:
##########
@@ -441,7 +447,39 @@ fn prepare_search(
if top_k == 0 {
return Ok(None);
}
- let nprobe = int_parameter(options, NPROBE_PARAMETER, DEFAULT_NPROBE)?;
+ let mut params = match metadata.index_type {
+ IndexType::DiskAnn => {
+ if options.contains_key(NPROBE_PARAMETER) {
Review Comment:
[P2] Ignore tuning options for the other backend
Different global-index types are explicitly allowed to coexist on the same
field, and the search path fans the same merged option map out to every
matching entry. If IVF and DiskANN indexes coexist, a legitimate `ivf.nprobe`
reaches the DiskANN reader here and aborts the entire query; the inverse
happens when an IVF reader sees the DiskANN knob. Please consume only the
option applicable to `metadata.index_type` and ignore the recognized option for
the other backend, or partition the options before fan-out. A mixed IVF +
DiskANN regression test would cover this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
