dalingmeng commented on code in PR #198:
URL: https://github.com/apache/paimon-cpp/pull/198#discussion_r3810967040


##########
src/paimon/common/utils/arrow/vector_utils.h:
##########


Review Comment:
   Dead code: `VectorUtils::ValidateNestedVectorElements` has no production 
caller — only its own recursion and one unit test reference it. Nested VECTOR 
validation is already covered by `InnerCheckNullabilityMatch` (write path) and 
by the recursion in `ConvertToReadType`/`ConvertToWriteType`. Suggest removing 
it (and its test), or wiring it in as the single entry point if that was the 
intent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to