JingsongLi commented on code in PR #9195:
URL: https://github.com/apache/paimon/pull/9195#discussion_r3818211025
##########
paimon-core/src/main/java/org/apache/paimon/table/sink/BatchTableCommit.java:
##########
@@ -73,6 +74,14 @@ public interface BatchTableCommit extends TableCommit {
/** Compact the manifest entries. Generates a snapshot with {@link
CommitKind#COMPACT}. */
void compactManifests();
+ /**
+ * Replace the manifest entries with the given rewritten manifests. The
{@code removedManifests}
+ * are the manifests the caller read and sorted; the {@code
addedManifests} are the sorted
+ * rewrite result. Generates a snapshot with {@link CommitKind#COMPACT}.
+ */
+ void replaceManifests(
Review Comment:
[P1] Keep the new operation out of the abstract public API
`BatchTableCommit` is annotated `@Public`; adding a new abstract method
makes every external implementation source-incompatible, and binaries compiled
against the old interface can fail with `AbstractMethodError` if this operation
reaches them. This procedure only needs Paimon’s internal commit
implementation. Please expose it through an internal interface/type, or at
minimum make this a default method that throws `UnsupportedOperationException`
so existing public implementations remain compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
