lxy-9602 commented on code in PR #211:
URL: https://github.com/apache/paimon-cpp/pull/211#discussion_r3817939540
##########
include/paimon/table/source/scan_metrics.h:
##########
@@ -30,6 +32,21 @@ class ScanMetrics {
static constexpr char LAST_SCANNED_MANIFESTS[] = "lastScannedManifests";
static constexpr char LAST_SCAN_SKIPPED_TABLE_FILES[] =
"lastScanSkippedTableFiles";
static constexpr char LAST_SCAN_RESULTED_TABLE_FILES[] =
"lastScanResultedTableFiles";
+ static constexpr char LAST_MANIFEST_READ_DURATION[] =
"lastManifestReadDuration";
+ // Histogram metric for manifest-list and manifest-entry read duration
(milliseconds).
+ static constexpr char MANIFEST_READ_DURATION[] = "manifestReadDuration";
+ static constexpr char LAST_SNAPSHOT_CACHE_ENABLED[] =
"lastSnapshotCacheEnabled";
+ static constexpr char LAST_SNAPSHOT_CACHE_HIT[] = "lastSnapshotCacheHit";
+ static constexpr char SNAPSHOT_CACHE_HITS[] = "snapshotCacheHits";
+ static constexpr char SNAPSHOT_CACHE_MISSES[] = "snapshotCacheMisses";
+ static constexpr char LAST_SNAPSHOT_CACHE_LOAD_DURATION[] =
"lastSnapshotCacheLoadDuration";
+ static constexpr char SNAPSHOT_CACHE_LOAD_DURATION[] =
"snapshotCacheLoadDuration";
+ static constexpr char LAST_SNAPSHOT_CACHE_STORE_DURATION[] =
"lastSnapshotCacheStoreDuration";
+ static constexpr char SNAPSHOT_CACHE_STORE_DURATION[] =
"snapshotCacheStoreDuration";
+ // Candidate manifest-entry rows inspected by lazy scan filtering.
+ static constexpr char LAST_LAZY_DECODE_SCANNED_ROWS[] =
"lastLazyDecodeScannedRows";
+ // Full manifest entries retained after lazy scan filtering.
+ static constexpr char LAST_LAZY_DECODE_MATERIALIZED_ROWS[] =
"lastLazyDecodeMaterializedRows";
Review Comment:
Could you please add comments to clearly distinguish the metrics that exist
only in C++ but not in Java?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
