lucasfang commented on PR #211: URL: https://github.com/apache/paimon-cpp/pull/211#issuecomment-5422753122
Thank you for your contribution. I reviewed the prefetch-related part at 33f83bb. Overall the design is sound — routing `DelegatingPrefetchReader::GetReaderMetrics()` through `prefetch_reader_` is a real fix (previously, when the adaptive strategy disabled prefetch, `GetReader()` returned `readers_[0]`, snapshot semantics via `MetricsImpl::Overwrite` are correct, `MetricsInputStream` covers every `InputStream`/`Stream` virtual, and the async callback captures the metrics state by `shared_ptr` so a late completion cannot outlive it. A few things I'd like to see addressed before merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
