lxy-9602 commented on code in PR #205:
URL: https://github.com/apache/paimon-cpp/pull/205#discussion_r3827500799
##########
src/paimon/common/fs/object_store_file_system.h:
##########
@@ -31,6 +36,68 @@
namespace paimon {
+inline int64_t ParseObjectStoreModificationTime(const std::string& value) {
+ std::tm parsed_time{};
Review Comment:
Thank you very much for the PR and for your patience with the revisions. I
have one small comment: would it be possible to move
`ParseObjectStoreModificationTime` into a class as a static utility function?
We generally try to avoid global functions in production code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
