zjw1111 commented on code in PR #205:
URL: https://github.com/apache/paimon-cpp/pull/205#discussion_r3795281215
##########
cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1359,6 +1373,106 @@ macro(build_jindosdk_nextarch)
add_dependencies(jindosdk::nextarch jindosdk-nextarch_ep)
endmacro()
+macro(build_oss_sdk_v2)
+ message(STATUS "Building Alibaba Cloud OSS C++ SDK v2 from source")
+ find_package(CURL REQUIRED)
+ find_package(Threads REQUIRED)
+
+ set(OSS_SDK_V2_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/oss_sdk_v2_ep-install")
+ set(OSS_SDK_V2_INCLUDE_DIR "${OSS_SDK_V2_PREFIX}/include")
+ set(OSS_SDK_V2_INSTALL_LIBDIR "${CMAKE_INSTALL_LIBDIR}")
+ set(OSS_SDK_V2_LIB_DIR "${OSS_SDK_V2_PREFIX}/${OSS_SDK_V2_INSTALL_LIBDIR}")
+ set(OSS_SDK_V2_STATIC_LIB
+
"${OSS_SDK_V2_LIB_DIR}/${CMAKE_STATIC_LIBRARY_PREFIX}alibabacloud-oss-cpp-sdk-v2${CMAKE_STATIC_LIBRARY_SUFFIX}"
+ )
+
+ set(OSS_SDK_V2_CMAKE_CXX_FLAGS "${EP_CXX_FLAGS} -Wno-error")
+ set(OSS_SDK_V2_CMAKE_C_FLAGS "${EP_C_FLAGS} -Wno-error")
+ string(REPLACE "-Werror" "" OSS_SDK_V2_CMAKE_CXX_FLAGS
${OSS_SDK_V2_CMAKE_CXX_FLAGS})
Review Comment:
maybe can direct use `EP_CXX_FLAGS`/`EP_C_FLAGS`
<img width="1698" height="324" alt="Image"
src="https://github.com/user-attachments/assets/6d55a02b-84b3-4f9e-ada5-c7165ea97bf6";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
