zhoulii commented on code in PR #9321:
URL: https://github.com/apache/paimon/pull/9321#discussion_r3840320878
##########
paimon-core/src/main/java/org/apache/paimon/manifest/ManifestFile.java:
##########
@@ -363,6 +375,11 @@ public boolean isCacheEnabled() {
return cache != null;
}
+ /** Returns whether a manifest of this size is eligible for the
configured cache. */
+ public boolean isCacheable(long fileSize) {
Review Comment:
Do you mean why cached reads cannot use projection as well?
Currently, projection is only supported by the file reader, while the cache
stores and materializes full manifest entries. This change preserves the
existing full-cache path for cacheable manifests and applies file-level
projection only when the manifest cannot be cached.
Cache-side projected materialization could be added as a separate
optimization. Is that what you are suggesting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
