zhoulii commented on code in PR #9321:
URL: https://github.com/apache/paimon/pull/9321#discussion_r3831209257
##########
paimon-core/src/main/java/org/apache/paimon/manifest/ManifestFile.java:
##########
@@ -363,6 +375,11 @@ public boolean isCacheEnabled() {
return cache != null;
}
+ /** Returns whether a manifest of this size is eligible for the
configured cache. */
+ public boolean isCacheable(long fileSize) {
Review Comment:
isCacheable(fileSize) is intentional. When a manifest exceeds
maxElementSize, ObjectsCache bypasses it even if caching is enabled. Using
isCacheEnabled() would unnecessarily disable projected scans for
these large, non-cacheable manifests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
