gripleaf commented on code in PR #242:
URL: https://github.com/apache/paimon-cpp/pull/242#discussion_r3852364709
##########
src/paimon/core/manifest/manifest_file.cpp:
##########
@@ -93,8 +93,9 @@ Status ManifestFile::ReadBucketEntries(const std::string&
file_name, int32_t buc
file_name,
[this, bucket, entries](const std::shared_ptr<arrow::StructArray>&
batch) -> Status {
const arrow::ArrayVector& fields = batch->fields();
+ ColumnarRow row(fields, pool_, /*row_id=*/0);
Review Comment:
Avro can skip Validate() because the arrays are built entirely through Arrow
Builders from a controlled schema, without manually reconstructing ArrayData.
ORC and Parquet are different because both paths may manually transform or
reconstruct Arrow arrays. In those cases, Validate() is still useful for
catching invalid Arrow invariants before they cause an internal abort, so we
should keep it there. @zjw1111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
