lxy-9602 commented on code in PR #247:
URL: https://github.com/apache/paimon-cpp/pull/247#discussion_r3860975061
##########
src/paimon/core/table/source/data_split_test.cpp:
##########
@@ -172,7 +175,10 @@ TEST(DataSplitTest, TestDeserializeVersion8WithWriteCols) {
.value());
ASSERT_EQ(*result_data_split, *expected_data_split) <<
result_data_split->ToString();
ASSERT_OK_AND_ASSIGN(std::string serialize_bytes,
Split::Serialize(result_data_split, pool));
- ASSERT_EQ(serialize_bytes, std::string(split_bytes.data(),
split_bytes.size()));
+ ASSERT_OK_AND_ASSIGN(std::shared_ptr<Split> roundtrip,
+ Split::Deserialize(serialize_bytes.data(),
serialize_bytes.size(), pool));
+ auto roundtrip_data_split =
std::dynamic_pointer_cast<DataSplitImpl>(roundtrip);
+ ASSERT_EQ(*roundtrip_data_split, *expected_data_split) <<
roundtrip_data_split->ToString();
}
Review Comment:
Thanks a lot for syncing the protocol. Could you also add a serialization
compatibility test using the latest Java-generated file in
`data_split_test.cpp` and `commit_message_test.cpp`? Please refer to
`DataSplitTest::TestDeserializeVersion8WithWriteColsAndExternalPath`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
