lszskye commented on code in PR #247:
URL: https://github.com/apache/paimon-cpp/pull/247#discussion_r3868317747
##########
src/paimon/core/io/data_file_meta.h:
##########
@@ -47,18 +47,20 @@ struct DataFileMeta {
static const BinaryRow& EmptyMaxKey();
static constexpr int32_t DUMMY_LEVEL = 0;
- DataFileMeta(const std::string& _file_name, int64_t _file_size, int64_t
_row_count,
- const BinaryRow& _min_key, const BinaryRow& _max_key,
- const SimpleStats& _key_stats, const SimpleStats&
_value_stats,
- int64_t _min_sequence_number, int64_t _max_sequence_number,
int64_t _schema_id,
- int32_t _level, const
std::vector<std::optional<std::string>>& _extra_files,
- const Timestamp& _creation_time, const
std::optional<int64_t>& _delete_row_count,
- const std::shared_ptr<Bytes>& _embedded_index,
- const std::optional<FileSource>& _file_source,
- const std::optional<std::vector<std::string>>&
_value_stats_cols,
- const std::optional<std::string>& _external_path,
- const std::optional<int64_t>& _first_row_id,
- const std::optional<std::vector<std::string>>& _write_cols);
+ DataFileMeta(
+ const std::string& _file_name, int64_t _file_size, int64_t _row_count,
+ const BinaryRow& _min_key, const BinaryRow& _max_key, const
SimpleStats& _key_stats,
+ const SimpleStats& _value_stats, int64_t _min_sequence_number, int64_t
_max_sequence_number,
+ int64_t _schema_id, int32_t _level,
+ const std::vector<std::optional<std::string>>& _extra_files,
+ const Timestamp& _creation_time, const std::optional<int64_t>&
_delete_row_count,
+ const std::shared_ptr<Bytes>& _embedded_index,
+ const std::optional<FileSource>& _file_source,
+ const std::optional<std::vector<std::string>>& _value_stats_cols,
+ const std::optional<std::string>& _external_path,
+ const std::optional<int64_t>& _first_row_id,
+ const std::optional<std::vector<std::string>>& _write_cols,
+ const std::optional<std::vector<int64_t>>&
_column_max_sequence_numbers = std::nullopt);
Review Comment:
Please avoid using default values whenever possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
