lxy-9602 commented on code in PR #248:
URL: https://github.com/apache/paimon-cpp/pull/248#discussion_r3863098554
##########
include/paimon/defs.h:
##########
@@ -378,14 +378,34 @@ struct PAIMON_EXPORT Options {
/// @note: bitmap64 dv is not supported.
static const char DELETION_VECTOR_BITMAP64[];
- /// @note `CHANGELOG_PRODUCER` currently only support `none`
- ///
/// "changelog-producer" - Whether to double write to a changelog file.
This changelog file
/// keeps the details of data changes, it can be read directly during
stream reads. This can be
/// applied to tables with primary keys. Values can be "none", "input",
"lookup",
/// "full-compaction". Default value is "none".
+ /// @note C++ Paimon currently supports "none" and "input".
static const char CHANGELOG_PRODUCER[];
Review Comment:
lookup is also support?
##########
src/paimon/core/table/source/snapshot/changelog_follow_up_scanner.h:
##########
@@ -0,0 +1,50 @@
+/*
+ * Copyright 2026-present Alibaba Inc.
Review Comment:
check license
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]