lxy-9602 commented on code in PR #248:
URL: https://github.com/apache/paimon-cpp/pull/248#discussion_r3863349452
##########
src/paimon/core/operation/key_value_file_store_scan.cpp:
##########
@@ -176,9 +176,10 @@ Result<bool> KeyValueFileStoreScan::IsValueFilterEnabled()
const {
case ScanMode::ALL:
return value_filter_force_enabled_;
case ScanMode::DELTA:
+ case ScanMode::CHANGELOG:
return false;
Review Comment:
This path uses `ScanMode::CHANGELOG`, but
`KeyValueFileStoreScan::IsValueFilterEnabled()` disables value-stat pruning for
all changelog scans. Java enables it for `LOOKUP` and `FULL_COMPACTION`. Could
we align this behavior, or document it as a known performance gap?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
