lxy-9602 commented on code in PR #258:
URL: https://github.com/apache/paimon-cpp/pull/258#discussion_r3923058082
##########
test/inte/global_index_test.cpp:
##########
@@ -1504,6 +1507,98 @@ TEST_P(GlobalIndexTest, TestDataEvolutionBatchScan) {
}
}
+TEST_P(GlobalIndexTest, TestDataEvolutionGlobalIndexSnapshotSelection) {
+ CreateTable();
+ std::string table_path = PathUtil::JoinPath(dir_->Str(), "foo.db/bar");
+ auto schema = arrow::schema(fields_);
+ std::vector<std::string> write_cols = schema->field_names();
+ auto src_array =
arrow::ipc::internal::json::ArrayFromJSON(arrow::struct_(fields_), R"([
+["Alice", 10, 1, 11.1],
+["Bob", 20, 0, 12.1]
+ ])")
+ .ValueOrDie();
+
+ ASSERT_OK_AND_ASSIGN(auto commit_msgs, WriteArray(table_path, write_cols,
src_array));
+ ASSERT_OK(Commit(table_path, commit_msgs));
+ ASSERT_OK(WriteIndex(table_path, /*partition_filters=*/{}, "f0", "bitmap",
/*options=*/{},
+ Range(0, 1)));
+
+ auto predicate =
+ PredicateBuilder::Equal(/*field_index=*/0, /*field_name=*/"f0",
FieldType::STRING,
+ Literal(FieldType::STRING, "missing", 7));
+
+ ASSERT_OK_AND_ASSIGN(auto latest_plan, ScanGlobalIndexAndData(table_path,
predicate));
+ ASSERT_TRUE(latest_plan->Splits().empty());
+ ASSERT_EQ(latest_plan->SnapshotId(), std::optional<int64_t>(2));
+
+ const std::map<std::string, std::string> explicit_latest_options = {
+ {Options::SCAN_MODE, "latest"},
+ {Options::SCAN_SNAPSHOT_ID, "999"},
+ {Options::SCAN_TAG_NAME, "ignored"},
+ {Options::SCAN_TIMESTAMP_MILLIS, "0"}};
+ ASSERT_OK_AND_ASSIGN(auto explicit_latest_plan,
+ ScanGlobalIndexAndData(table_path, predicate,
explicit_latest_options));
+ ASSERT_TRUE(explicit_latest_plan->Splits().empty());
+ ASSERT_EQ(explicit_latest_plan->SnapshotId(), std::optional<int64_t>(2));
+
+ auto empty_index_result = BitmapGlobalIndexResult::FromRanges({});
+ ASSERT_OK_AND_ASSIGN(auto supplied_latest_plan,
+ ScanGlobalIndexAndData(table_path,
/*predicate=*/nullptr,
+ explicit_latest_options,
empty_index_result));
+ ASSERT_TRUE(supplied_latest_plan->Splits().empty());
+ ASSERT_FALSE(supplied_latest_plan->SnapshotId());
+
+ ASSERT_OK_AND_ASSIGN(auto supplied_explicit_plan,
+ ScanGlobalIndexAndData(table_path,
/*predicate=*/nullptr,
+ {{Options::SCAN_SNAPSHOT_ID,
"1"},
+ {Options::SCAN_TAG_NAME,
"ignored"},
+
{Options::SCAN_TIMESTAMP_MILLIS, "0"}},
+ empty_index_result));
+ ASSERT_TRUE(supplied_explicit_plan->Splits().empty());
+ ASSERT_FALSE(supplied_explicit_plan->SnapshotId());
+
+ Result<std::shared_ptr<Plan>> missing_selector_result =
+ ScanGlobalIndexAndData(table_path, predicate, {{Options::SCAN_MODE,
"from-snapshot"}});
+ ASSERT_TRUE(missing_selector_result.status().IsInvalid())
Review Comment:
One minor suggestion: could you please use `ASSERT_NOK_WITH_MSG` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
