wangyong9999 commented on code in PR #282:
URL: https://github.com/apache/paimon-cpp/pull/282#discussion_r3932293803
##########
src/paimon/core/operation/scan_context_test.cpp:
##########
@@ -101,4 +101,25 @@ TEST(ScanContextTest, TestSetOptionsOverridesAddedOptions)
{
ASSERT_EQ(expected_options, ctx->GetOptions());
}
+TEST(ScanContextTest, TestDefaultExecutorIsGlobalSingleton) {
Review Comment:
Once the fallback becomes a private `CreateDefaultExecutor()` (per the
thread above), this test pins the opposite of the new behavior. Worth flipping
it to: `Finish()` without `WithExecutor()` yields a non-null executor that is
not `GetGlobalDefaultExecutor()` and differs between two contexts; an executor
passed to `WithExecutor()` is used for the next `Finish()` only. That checks
the isolation the maintainer asked for instead of the singleton.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
