wangyong9999 commented on code in PR #282:
URL: https://github.com/apache/paimon-cpp/pull/282#discussion_r3939804397
##########
src/paimon/core/operation/scan_context_test.cpp:
##########
@@ -101,4 +101,25 @@ TEST(ScanContextTest, TestSetOptionsOverridesAddedOptions)
{
ASSERT_EQ(expected_options, ctx->GetOptions());
}
+TEST(ScanContextTest, TestDefaultExecutorIsGlobalSingleton) {
Review Comment:
Done. `TestDefaultExecutorIsGlobalSingleton` was replaced by
`TestDefaultExecutorIsCreatedPerContext` in 3475256: `Finish()` without
`WithExecutor()` yields a non-null executor that differs between two contexts,
and an executor passed to `WithExecutor()` applies to the next `Finish()` only.
5ca87e38 adds the remaining piece, an explicit
`ASSERT_NE(GetGlobalDefaultExecutor(), ...)` for both contexts, so a regression
back to the singleton is caught directly. `ScanContextTest.*` passes locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
