XiaoHongbo-Hope commented on code in PR #278:
URL: https://github.com/apache/paimon-cpp/pull/278#discussion_r3934436306
##########
src/paimon/common/types/data_type_json_parser_test.cpp:
##########
@@ -158,6 +160,11 @@ TEST(DataTypeJsonParserTest, ParseTypeAtomicTypeSuccess) {
{"NUMERIC", arrow::decimal128(10, 0)},
{"NUMERIC(10)", arrow::decimal128(10, 0)},
{"NUMERIC(10, 3)", arrow::decimal128(10, 3)},
+ {"TIME", arrow::time32(arrow::TimeUnit::MILLI)},
+ {"TIME(0)", arrow::time32(arrow::TimeUnit::MILLI)},
+ {"TIME(3)", arrow::time32(arrow::TimeUnit::MILLI)},
+ {"TIME(9)", arrow::time32(arrow::TimeUnit::MILLI)},
+ {"TIME(3) WITHOUT TIME ZONE", arrow::time32(arrow::TimeUnit::MILLI)},
Review Comment:
> Please also add ut for "TIME(6) WITHOUT TIME ZONE"...
Removed TIME support in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
