XiaoHongbo-Hope commented on code in PR #278: URL: https://github.com/apache/paimon-cpp/pull/278#discussion_r3946025954
########## test/test_data/parquet/map_blob_java.db/map_blob_java/README.md: ########## @@ -0,0 +1,26 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> Review Comment: Removed the license header and expanded the fixture README with the schema, table options, exact row contents, and the generation steps for snapshots 1-3 in fd14fb68. ########## src/paimon/format/blob/blob_file_batch_reader.cpp: ########## @@ -133,9 +257,14 @@ Status BlobFileBatchReader::SetReadSchema(::ArrowSchema* read_schema, return Status::Invalid( fmt::format("read schema field number {} is not 1", arrow_schema->num_fields())); } - if (!BlobUtils::IsBlobField(arrow_schema->field(0))) { - return Status::Invalid( - fmt::format("field {} is not BLOB", arrow_schema->field(0)->ToString())); + std::shared_ptr<arrow::Field> read_field = arrow_schema->field(0); + if (!BlobUtils::IsBlobField(read_field) && !BlobUtils::IsMapBlobField(read_field)) { + return Status::Invalid(fmt::format("field {} is not BLOB", read_field->ToString())); + } Review Comment: Updated the validation message to explicitly require BLOB or MAP<..., BLOB>, and adjusted the SetReadSchema regression test in fd14fb68. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
