lxy-9602 commented on PR #284: URL: https://github.com/apache/paimon-cpp/pull/284#issuecomment-5550430426
C++ already performs predicate-to-bucket conversion for `KeyValueFileStoreScan`, while this PR introduces a second append-specific path with different semantics. Java installs a shared total-aware selector for both scan types and computes the bucket using each manifest entry’s totalBucket. Could we centralize this in `FileStoreScan` and make the selector total-aware like java? Besides avoiding duplication, this would prevent the existing KV path from pruning historical files incorrectly after bucket rescaling. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
