wangyong9999 commented on PR #284:
URL: https://github.com/apache/paimon-cpp/pull/284#issuecomment-5551144682

   @lxy-9602 Fixed in 9aca26db. I reproduced the KV bug: with the current 
option set to 4 buckets, a matching file written with 2 buckets was discarded.
   
   Selector setup and entry filtering now live in `FileStoreScan`. Both scans 
reuse the key row and bucket function, then compute the bucket from each 
entry's `TotalBuckets()`. The append-specific path and KV's inferred global 
bucket filter are removed.
   
   Explicit bucket filters still take precedence. Different schema IDs retain 
the conservative fallback. Inferred KV scans now also skip the manifest-level 
bucket optimization and bucket-specific cache, since a single inferred bucket 
is unsafe across rescaling. The description calls out this tradeoff.
   
   Added regressions for both scans and extended the real-file scan/read tests 
to current bucket options of 2, 4, 8 and 17. The two unit regressions failed 
before the fix; 46 unit tests and 81 integration tests pass now. The build and 
pre-commit checks pass too.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to