zhang-arvin commented on PR #9504: URL: https://github.com/apache/paimon/pull/9504#issuecomment-5574158987
Thanks @JingsongLi — [P2] is a fair point and I agree with the direction. As the PR stands, both "old reader" tests round-trip current-version JSON through the current reader, so a change that an older release couldn't parse would still go green: that's a false compatibility gate, exactly the thing #3531 asks to protect. Plan accepted: (1) old-writer → current-reader direction via checked-in fixtures generated by a pinned prior release (real snapshot/schema JSON plus manifest and data files), so HEAD must parse genuine old-release output; (2) current-writer → old-reader direction via a pinned old-release reader running against HEAD-produced files in an isolated classloader/process — as you note, that direction genuinely needs the old artifact. I'll restructure the two test classes around that harness. On CI: I root-caused the all-matrix failure — the jobs never reached the tests. Both new test files trip checkstyle `NewlineAtEndOfFile`, which fails the `validate` phase of the paimon-core build that every `build_test` job depends on. Local runs passed only because I built with `-Pfast-build`, which skips checkstyle. I'll fix the newlines, run checkstyle locally before pushing, and report the real test results from the next CI run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
