JingsongLi commented on PR #9504: URL: https://github.com/apache/paimon/pull/9504#issuecomment-5748014835
Requirement fit: UNSUPPORTED for the current implementation. Implementation: FINDINGS. This still does not implement #3531's cross-version contract. The only changed files are two current-source test classes; `testNewSnapshotJsonCompatibleWithOldReader` serializes with HEAD and calls HEAD's `Snapshot.fromJson`, and the schema tests follow the same pattern. There is no pinned prior-release artifact, isolated old classloader/process, or release-generated manifest/data fixture. A format that HEAD accepts but every supported old release rejects would therefore keep these tests green. The PR also currently fails essentially the full Java matrix before these tests run because both new files violate `NewlineAtEndOfFile`. Adding 837 lines of synthetic same-version JSON tests creates maintenance cost while providing a false compatibility gate, so there is no end-to-end compatibility value to merge in this form. Closing this PR. Please open a focused replacement when it runs a real old-writer → HEAD-reader fixture and HEAD-writer → pinned-old-reader flow, including metadata, manifests and data files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
