Stephen0421 commented on code in PR #9608:
URL: https://github.com/apache/paimon/pull/9608#discussion_r3987435139
##########
paimon-python/pypaimon/filesystem/resolving_file_io.py:
##########
@@ -137,7 +138,18 @@ def write_row(self, path: str, data, fields=None,
zstd_level: int = 1, **kwargs)
return self._get_fileio(path).write_row(path, data, fields,
zstd_level, **kwargs)
+ @property
+ def uri_reader_factory(self):
Review Comment:
Thanks — agreed.
Java `FileIO` does not own a `UriReaderFactory`; the factory wraps `FileIO`.
The read path already does that via `UriReaderFactory.from_file_io(file_io)`
(`OffsetRow`, convert reader, `BlobViewLookup`), so
`ResolvingFileIO.uri_reader_factory` was not needed for this change.
I dropped the property and the `close()` lifecycle that went with it.
`BlobFileWriter` still reaching through `file_io.uri_reader_factory` is a
pre-existing write-path assumption; I'll pass the factory explicitly at that
boundary in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
