Stephen0421 commented on PR #9608: URL: https://github.com/apache/paimon/pull/9608#issuecomment-5748860303
> Still close in FileIO? Yes — that was the rest of the same cut. Last round I dropped `ResolvingFileIO.uri_reader_factory` but left `FileIO.close()` calling `uri_reader_factory.close()` on `LocalFileIO`, `PyArrowFileIO`, `HdfsNativeFileIO`, and `RESTTokenFileIO`. Those closes were added in this PR; they are factory lifecycle on FileIO, which you already asked not to extend here. I removed them. The factory still has `close()` for whoever creates it. The remaining `file_io.uri_reader_factory` fields are the pre-existing write-path assumption and will move to an explicit factory at that boundary in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
